Merge ccabbe5bec4ea62fb05747154b0027f70ab3c811 into 5661c20580584d86897d139cdeffd6fb1a9a6d5c

crates/typst-html/src/convert.rs

@@ -1,3 +1,5 @@
+use crate::fragment::html_fragment;
+use crate::{attr, tag, FrameElem, HtmlElem, HtmlElement, HtmlFrame, HtmlNode};
 use typst_library::diag::{warning, SourceResult};
 use typst_library::engine::Engine;
 use typst_library::foundations::{Content, StyleChain, Target, TargetElem};
@@ -5,10 +7,10 @@ use typst_library::introspection::{SplitLocator, TagElem};
 use typst_library::layout::{Abs, Axes, BlockBody, BlockElem, BoxElem, Region, Size};
 use typst_library::model::ParElem;
 use typst_library::routines::Pair;
-use typst_library::text::{LinebreakElem, SmartQuoteElem, SpaceElem, TextElem};
+use typst_library::text::{
-
+    is_default_ignorable, LinebreakElem, SmartQuoteElem, SmartQuoter, SmartQuotes,
-use crate::fragment::html_fragment;
+    SpaceElem, TextElem,
-use crate::{attr, tag, FrameElem, HtmlElem, HtmlElement, HtmlFrame, HtmlNode};
+};
 
 /// Converts realized content into HTML nodes.
 pub fn convert_to_nodes<'a>(
@@ -16,9 +18,10 @@ pub fn convert_to_nodes<'a>(
     locator: &mut SplitLocator,
     children: impl IntoIterator<Item = Pair<'a>>,
 ) -> SourceResult<Vec<HtmlNode>> {
+    let mut quoter = SmartQuoter::new();
     let mut output = Vec::new();
     for (child, styles) in children {
-        handle(engine, child, locator, styles, &mut output)?;
+        handle(engine, child, locator, styles, &mut quoter, &mut output)?;
     }
     Ok(output)
 }
@@ -29,6 +32,7 @@ fn handle(
     child: &Content,
     locator: &mut SplitLocator,
     styles: StyleChain,
+    quoter: &mut SmartQuoter,
     output: &mut Vec<HtmlNode>,
 ) -> SourceResult<()> {
     if let Some(elem) = child.to_packed::<TagElem>() {
@@ -95,10 +99,20 @@ fn handle(
     } else if let Some(elem) = child.to_packed::<LinebreakElem>() {
         output.push(HtmlElement::new(tag::br).spanned(elem.span()).into());
     } else if let Some(elem) = child.to_packed::<SmartQuoteElem>() {
-        output.push(HtmlNode::text(
+        let double = elem.double.get(styles);
-            if elem.double.get(styles) { '"' } else { '\'' },
+        if elem.enabled.get(styles) {
-            child.span(),
+            let before = last_char(output);
-        ));
+            let quotes = SmartQuotes::get(
+                elem.quotes.get_ref(styles),
+                styles.get(TextElem::lang),
+                styles.get(TextElem::region),
+                elem.alternative.get(styles),
+            );
+            let quote = quoter.quote(before, &quotes, double);
+            output.push(HtmlNode::text(quote, child.span()));
+        } else {
+            output.push(HtmlNode::text(if double { '"' } else { '\'' }, child.span()));
+        }
     } else if let Some(elem) = child.to_packed::<FrameElem>() {
         let locator = locator.next(&elem.span());
         let style = TargetElem::target.set(Target::Paged).wrap();
@@ -120,6 +134,20 @@ fn handle(
     Ok(())
 }
 
+/// Returns the last non-default ignorable character from the passed nodes.
+fn last_char(nodes: &[HtmlNode]) -> Option<char> {
+    for node in nodes.iter().rev() {
+        if let Some(c) = match node {
+            HtmlNode::Text(s, _) => s.chars().rev().find(|&c| !is_default_ignorable(c)),
+            HtmlNode::Element(e) => last_char(&e.children),
+            _ => None,
+        } {
+            return Some(c);
+        }
+    }
+    None
+}
+
 /// Checks whether the given element is an inline-level HTML element.
 pub fn is_inline(elem: &Content) -> bool {
     elem.to_packed::<HtmlElem>()

crates/typst-library/src/foundations/selector.rs

@@ -37,13 +37,12 @@ pub use crate::__select_where as select_where;
 
 /// A filter for selecting elements within the document.
 ///
-/// You can construct a selector in the following ways:
+/// To construct a selector you can:
-/// - you can use an element [function]
+/// - use an element [function]
-/// - you can filter for an element function with
+/// - filter for an element function with [specific fields]($function.where)
-///   [specific fields]($function.where)
+/// - use a [string]($str) or [regular expression]($regex)
-/// - you can use a [string]($str) or [regular expression]($regex)
+/// - use a [`{<label>}`]($label)
-/// - you can use a [`{<label>}`]($label)
+/// - use a [`location`]
-/// - you can use a [`location`]
 /// - call the [`selector`] constructor to convert any of the above types into a
 ///   selector value and use the methods below to refine it
 ///
@@ -148,7 +147,9 @@ impl Selector {
 impl Selector {
     /// Turns a value into a selector. The following values are accepted:
     /// - An element function like a `heading` or `figure`.
+    /// - A [string]($str) or [regular expression]($regex).
     /// - A `{<label>}`.
+    /// - A [`location`].
     /// - A more complex selector like `{heading.where(level: 1)}`.
     #[func(constructor)]
     pub fn construct(

tests/ref/html/par-semantic-html.html

@@ -6,8 +6,8 @@
   </head>
   <body>
     <h2>Heading is no paragraph</h2>
-    <p>I'm a paragraph.</p>
+    <p>I’m a paragraph.</p>
-    <div>I'm not.</div>
+    <div>I’m not.</div>
     <div>
       <p>We are two.</p>
       <p>So we are paragraphs.</p>

tests/ref/html/quote-nesting-html.html

@@ -5,6 +5,6 @@
     <meta name="viewport" content="width=device-width, initial-scale=1">
   </head>
   <body>
-    <p>When you said that “he surely meant that ‘she intended to say “I'm sorry”’”, I was quite confused.</p>
+    <p>When you said that “he surely meant that ‘she intended to say “I’m sorry”’”, I was quite confused.</p>
   </body>
 </html>

tests/ref/html/smartquotes-html.html

@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1">
+  </head>
+  <body>
+    <p>When you said that “he surely meant that ‘she intended to say “I’m sorry”’”, I was quite confused.</p>
+    <p>‘<span style="display: inline-block;">box</span>’</p>
+  </body>
+</html>

tests/suite/text/smartquote.typ

@@ -172,3 +172,8 @@ Some people's thought on this would be #[#set smartquote(enabled: false); "stran
 
 --- issue-5146-smartquotes-after-equations ---
 $i$'s $i$ 's
+
+--- smartquotes-html html ---
+When you said that "he surely meant that 'she intended to say "I'm sorry"'", I was quite confused.
+
+'#box[box]'