From fd5e642fb495e98bde0f7e7fd16dca7ac355c60a Mon Sep 17 00:00:00 2001
From: Max <me@mkor.je>
Date: Tue, 26 Nov 2024 12:37:53 +0000
Subject: [PATCH] Tags shouldn't affect row height in equations (#5458)

---
 crates/typst-layout/src/math/run.rs               |   5 ++++-
 .../ref/math-equation-tag-affects-row-height.png  | Bin 0 -> 329 bytes
 tests/suite/math/equation.typ                     |   9 +++++++++
 3 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 tests/ref/math-equation-tag-affects-row-height.png

diff --git a/crates/typst-layout/src/math/run.rs b/crates/typst-layout/src/math/run.rs
index 8f12c5098..b07f5893a 100644
--- a/crates/typst-layout/src/math/run.rs
+++ b/crates/typst-layout/src/math/run.rs
@@ -419,7 +419,10 @@ impl MathRunFrameBuilder {
 }
 
 fn affects_row_height(fragment: &MathFragment) -> bool {
-    !matches!(fragment, MathFragment::Align | MathFragment::Linebreak)
+    !matches!(
+        fragment,
+        MathFragment::Align | MathFragment::Linebreak | MathFragment::Tag(_)
+    )
 }
 
 /// Create the spacing between two fragments in a given style.
diff --git a/tests/ref/math-equation-tag-affects-row-height.png b/tests/ref/math-equation-tag-affects-row-height.png
new file mode 100644
index 0000000000000000000000000000000000000000..d0cc235993bbdf4c0ac463e42f91a8d107ab68d9
GIT binary patch
literal 329
zcmV-P0k-~$P)<h;3K|Lk000e1NJLTq004LZ001or00000KuqvT0003HNkl<Zc-mw5
zKR|$C)Z$T#M=c(;c+}!ii$^WSV)3C?5NNx)4opwH`~Uy(Rxr4*1x$6{9S!PHi$^Uc
z(&D>du%@AI8iWNC*;3mu0VZ;$6%0=81XG>2|Np-T5jnaKk{NH1Yw<a&yPZ8K7GE*D
zJ*^%t0tdK6$hEku<Zj4e6hmjE-A&w1dy8lFp4FRs1KH3O4HvZ+U!=Lkx8^RIxgN#P
zJM-qxT}eY9<2Q7qTfDBcwiZ=nTVZ_}?Jd4)bZ34!ipWi)8*8&^Z}FnIyP4}zQvUkD
zyJd^6)7;`ch37OEo<SBlk$OpQ;UO@S7A+9CQ`RoovKrNK8y4<d3So`bPNNo&T0Cm;
b@U<8K_xWY5iR9bD00000NkvXXu0mjf3lWjF

literal 0
HcmV?d00001

diff --git a/tests/suite/math/equation.typ b/tests/suite/math/equation.typ
index 6cdf7b7ed..148a49d02 100644
--- a/tests/suite/math/equation.typ
+++ b/tests/suite/math/equation.typ
@@ -260,6 +260,15 @@ $ q &= sum_k ln A \
 // Test numbering on empty equations.
 #math.equation(numbering: "1", block: true, [])
 
+--- math-equation-tag-affects-row-height ---
+// Tags should not affect the row height of equations.
+#box($ - - $, fill: silver)
+#box($ #metadata(none) - - $, fill: silver) \
+#box($ a \ - - $, fill: silver)
+#box($ a \ #metadata(none) - - $, fill: silver)
+#box($ - - \ a $, fill: silver)
+#box($ #metadata(none) - - \ a $, fill: silver)
+
 --- issue-4187-alignment-point-affects-row-height ---
 // In this bug, a row of "-" only should have a very small height; but
 // after adding an alignment point "&", the row gains a larger height.