caisin/typst
1
0
Fork 0
mirror of https://github.com/typst/typst synced 2025-08-26 04:34:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fail on empty label name (#5776)

Browse Source
This commit is contained in:
Said Aroua 2025-05-25 15:02:34 +02:00
parent 2a258a0c38
commit c38558d9db
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
crates/typst-library/src/foundations/label.rs
View File

@ -1,7 +1,10 @@
use ecow::{eco_format, EcoString}; use ecow::{eco_format, EcoString};
use typst_utils::{PicoStr, ResolvedPicoStr}; use typst_utils::{PicoStr, ResolvedPicoStr};
use crate::foundations::{func, scope, ty, Repr, Str}; use crate::{
diag::StrResult,
foundations::{bail, func, scope, ty, Repr, Str},
};
/// A label for an element. /// A label for an element.
/// ///
@ -27,7 +30,8 @@ use crate::foundations::{func, scope, ty, Repr, Str};
/// # Syntax /// # Syntax
/// This function also has dedicated syntax: You can create a label by enclosing /// This function also has dedicated syntax: You can create a label by enclosing
/// its name in angle brackets. This works both in markup and code. A label's /// its name in angle brackets. This works both in markup and code. A label's
/// name can contain letters, numbers, `_`, `-`, `:`, and `.`. /// name can contain letters, numbers, `_`, `-`, `:`, and `.`. Empty label names
/// get rejected.
/// ///
/// Note that there is a syntactical difference when using the dedicated syntax /// Note that there is a syntactical difference when using the dedicated syntax
/// for this function. In the code below, the `[<a>]` terminates the heading and /// for this function. In the code below, the `[<a>]` terminates the heading and
@ -67,13 +71,17 @@ impl Label {
#[scope] #[scope]
impl Label { impl Label {
/// Creates a label from a string. /// Creates a label from a string. Fails for empty strings.
#[func(constructor)] #[func(constructor)]
pub fn construct( pub fn construct(
/// The name of the label. /// The name of the label.
name: Str, name: Str,
) -> Label { ) -> StrResult<Label> {
Self(PicoStr::intern(name.as_str())) if name.is_empty() {
bail!("expected non-empty label name");
}
Ok(Self(PicoStr::intern(name.as_str())))
} }
} }