caisin/typst
1
0
Fork 0
mirror of https://github.com/typst/typst synced 2025-05-13 20:46:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: catch indefinite loop in realization due to cycle between show and grouping rule

Browse Source
This commit is contained in:
Tobias Schmitz 2025-05-09 10:18:55 +02:00
parent 9b09146a6b
commit bc0f08081e
No known key found for this signature in database
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
crates/typst-realize/src/lib.rs
View File

@ -655,6 +655,7 @@ fn visit_grouping_rules<'a>(
let matching = s.rules.iter().find(|&rule| (rule.trigger)(content, &s.kind));
// Try to continue or finish an existing grouping.
let mut i = 0;
while let Some(active) = s.groupings.last() {
// Start a nested group if a rule with higher priority matches.
if matching.is_some_and(|rule| rule.priority > active.rule.priority) {
@ -670,6 +671,21 @@ fn visit_grouping_rules<'a>(
}
finish_innermost_grouping(s)?;
i += 1;
if i > 4096 {
// It seems like this case is only hit when there is a cycle between
// a show rule and a grouping rule. The show rule produces content
// that is matched by a grouping rule, which is then again processed
// by the show rule, and so on. The two must be at an equilibrium,
// otherwise either the "maximum show rule depth" or "maximum
// grouping depth" errors are triggered.
bail!(
content.span(),
"maximum realization iterations exceeded";
hint: "maybe there is a cycle between a show rule that produces content,\
which is matched by a grouping rule that triggers the show rule",
);
}
}
// Start a new grouping.