caisin/typst
1
0
Fork 0
mirror of https://github.com/typst/typst synced 2025-05-14 17:15:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't write multiple authors in XMP metadata

Browse Source 
Fixes #2556.
This commit is contained in:
Laurenz 2023-11-29 11:49:14 +01:00
parent 2007f30b11
commit af9d8727e1
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
crates/typst-pdf/src/lib.rs
View File

@ -183,8 +183,25 @@ fn write_catalog(ctx: &mut PdfContext, ident: Option<&str>, timestamp: Option<Da
let authors = &ctx.document.author; let authors = &ctx.document.author;
if !authors.is_empty() { if !authors.is_empty() {
info.author(TextStr(&authors.join(", "))); // Turns out that if the authors are given in both the document
xmp.creator(authors.iter().map(|s| s.as_str())); // information dictionary and the XMP metadata, Acrobat takes a little
// bit of both: The first author from the document information
// dictionary and the remaining authors from the XMP metadata.
//
// To fix this for Acrobat, we could omit the remaining authors or all
// metadata from the document information catalog (it is optional) and
// only write XMP. However, not all other tools (including Apple
// Preview) read the XMP data. This means we do want to include all
// authors in the document information dictionary.
//
// Thus, the only alternative is to fold all authors into a single
// `<rdf:li>` in the XMP metadata. This is, in fact, exactly what the
// PDF/A spec Part 1 section 6.7.3 has to say about the matter. It's a
// bit weird to not use the array (and it makes Acrobat show the author
// list in quotes), but there's not much we can do about that.
let joined = authors.join(", ");
info.author(TextStr(&joined));
xmp.creator([joined.as_str()]);
} }
let creator = eco_format!("Typst {}", env!("CARGO_PKG_VERSION")); let creator = eco_format!("Typst {}", env!("CARGO_PKG_VERSION"));