Merge 6594a0f530d42209c3c6f5f6a7e56fbff93b62e5 into 7278d887cf05fadc9a96478830e5876739b78f53

This commit is contained in:
T0mstone 2025-07-23 15:39:30 +00:00 committed by GitHub
commit 925f604366
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
16 changed files with 160 additions and 106 deletions

2
Cargo.lock generated
View File

@ -413,7 +413,7 @@ dependencies = [
[[package]] [[package]]
name = "codex" name = "codex"
version = "0.1.1" version = "0.1.1"
source = "git+https://github.com/typst/codex?rev=9ac86f9#9ac86f96af5b89fce555e6bba8b6d1ac7b44ef00" source = "git+https://github.com/typst/codex?rev=775d828#775d82873c3f74ce95ec2621f8541de1b48778a7"
[[package]] [[package]]
name = "color-print" name = "color-print"

View File

@ -47,7 +47,7 @@ clap = { version = "4.4", features = ["derive", "env", "wrap_help"] }
clap_complete = "4.2.1" clap_complete = "4.2.1"
clap_mangen = "0.2.10" clap_mangen = "0.2.10"
codespan-reporting = "0.11" codespan-reporting = "0.11"
codex = { git = "https://github.com/typst/codex", rev = "9ac86f9" } codex = { git = "https://github.com/typst/codex", rev = "775d828" }
color-print = "0.3.6" color-print = "0.3.6"
comemo = "0.4" comemo = "0.4"
csv = "1" csv = "1"

View File

@ -123,7 +123,7 @@ impl Eval for ast::Escape<'_> {
type Output = Value; type Output = Value;
fn eval(self, _: &mut Vm) -> SourceResult<Self::Output> { fn eval(self, _: &mut Vm) -> SourceResult<Self::Output> {
Ok(Value::Symbol(Symbol::single(self.get()))) Ok(Value::Symbol(Symbol::runtime_char(self.get())))
} }
} }
@ -131,7 +131,7 @@ impl Eval for ast::Shorthand<'_> {
type Output = Value; type Output = Value;
fn eval(self, _: &mut Vm) -> SourceResult<Self::Output> { fn eval(self, _: &mut Vm) -> SourceResult<Self::Output> {
Ok(Value::Symbol(Symbol::single(self.get()))) Ok(Value::Symbol(Symbol::runtime_char(self.get())))
} }
} }

View File

@ -49,7 +49,7 @@ impl Eval for ast::MathShorthand<'_> {
type Output = Value; type Output = Value;
fn eval(self, _: &mut Vm) -> SourceResult<Self::Output> { fn eval(self, _: &mut Vm) -> SourceResult<Self::Output> {
Ok(Value::Symbol(Symbol::single(self.get()))) Ok(Value::Symbol(Symbol::runtime_char(self.get())))
} }
} }

View File

@ -97,7 +97,7 @@ pub enum CompletionKind {
/// A font family. /// A font family.
Font, Font,
/// A symbol. /// A symbol.
Symbol(char), Symbol(EcoString),
} }
/// Complete in comments. Or rather, don't! /// Complete in comments. Or rather, don't!
@ -449,7 +449,7 @@ fn field_access_completions(
for modifier in symbol.modifiers() { for modifier in symbol.modifiers() {
if let Ok(modified) = symbol.clone().modified((), modifier) { if let Ok(modified) = symbol.clone().modified((), modifier) {
ctx.completions.push(Completion { ctx.completions.push(Completion {
kind: CompletionKind::Symbol(modified.get()), kind: CompletionKind::Symbol(modified.get().into()),
label: modifier.into(), label: modifier.into(),
apply: None, apply: None,
detail: None, detail: None,
@ -1366,7 +1366,7 @@ impl<'a> CompletionContext<'a> {
kind: kind.unwrap_or_else(|| match value { kind: kind.unwrap_or_else(|| match value {
Value::Func(_) => CompletionKind::Func, Value::Func(_) => CompletionKind::Func,
Value::Type(_) => CompletionKind::Type, Value::Type(_) => CompletionKind::Type,
Value::Symbol(s) => CompletionKind::Symbol(s.get()), Value::Symbol(s) => CompletionKind::Symbol(s.get().into()),
_ => CompletionKind::Constant, _ => CompletionKind::Constant,
}), }),
label, label,

View File

@ -300,6 +300,7 @@ impl GlyphFragment {
); );
let buffer = rustybuzz::shape_with_plan(font.rusty(), &plan, buffer); let buffer = rustybuzz::shape_with_plan(font.rusty(), &plan, buffer);
// TODO: deal with multiple glyphs.
if buffer.len() != 1 { if buffer.len() != 1 {
bail!(span, "did not get a single glyph after shaping {}", text); bail!(span, "did not get a single glyph after shaping {}", text);
} }

View File

@ -129,34 +129,41 @@ pub fn layout_symbol(
ctx: &mut MathContext, ctx: &mut MathContext,
styles: StyleChain, styles: StyleChain,
) -> SourceResult<()> { ) -> SourceResult<()> {
// Switch dotless char to normal when we have the dtls OpenType feature.
// This should happen before the main styling pass.
let dtls = style_dtls();
let (unstyled_c, symbol_styles) = match try_dotless(elem.text) {
Some(c) if has_dtls_feat(ctx.font) => (c, styles.chain(&dtls)),
_ => (elem.text, styles),
};
let variant = styles.get(EquationElem::variant); let variant = styles.get(EquationElem::variant);
let bold = styles.get(EquationElem::bold); let bold = styles.get(EquationElem::bold);
let italic = styles.get(EquationElem::italic); let italic = styles.get(EquationElem::italic);
let dtls = style_dtls();
let has_dtls_feat = has_dtls_feat(ctx.font);
for cluster in elem.text.graphemes(true) {
// Switch dotless char to normal when we have the dtls OpenType feature.
// This should happen before the main styling pass.
let mut enable_dtls = false;
let text: EcoString = cluster
.chars()
.flat_map(|mut c| {
if has_dtls_feat && let Some(d) = try_dotless(c) {
enable_dtls = true;
c = d;
}
to_style(c, MathStyle::select(c, variant, bold, italic))
})
.collect();
let styles = if enable_dtls { styles.chain(&dtls) } else { styles };
let style = MathStyle::select(unstyled_c, variant, bold, italic); let fragment: MathFragment =
let text: EcoString = to_style(unstyled_c, style).collect(); match GlyphFragment::new(ctx.font, styles, &text, elem.span()) {
Ok(mut glyph) => {
let fragment: MathFragment = adjust_glyph_layout(&mut glyph, ctx, styles);
match GlyphFragment::new(ctx.font, symbol_styles, &text, elem.span()) { glyph.into()
Ok(mut glyph) => { }
adjust_glyph_layout(&mut glyph, ctx, styles); Err(_) => {
glyph.into() // Not in the math font, fallback to normal inline text layout.
} // TODO: Should replace this with proper fallback in [`GlyphFragment::new`].
Err(_) => { layout_inline_text(&text, elem.span(), ctx, styles)?.into()
// Not in the math font, fallback to normal inline text layout. }
// TODO: Should replace this with proper fallback in [`GlyphFragment::new`]. };
layout_inline_text(&text, elem.span(), ctx, styles)?.into() ctx.push(fragment);
} }
};
ctx.push(fragment);
Ok(()) Ok(())
} }

View File

@ -1,5 +1,5 @@
use std::collections::{BTreeSet, HashMap}; use std::collections::{BTreeSet, HashMap};
use std::fmt::{self, Debug, Display, Formatter, Write}; use std::fmt::{self, Debug, Display, Formatter};
use std::sync::Arc; use std::sync::Arc;
use codex::ModifierSet; use codex::ModifierSet;
@ -8,7 +8,7 @@ use serde::{Serialize, Serializer};
use typst_syntax::{Span, Spanned, is_ident}; use typst_syntax::{Span, Spanned, is_ident};
use typst_utils::hash128; use typst_utils::hash128;
use crate::diag::{DeprecationSink, SourceResult, StrResult, bail}; use crate::diag::{DeprecationSink, SourceResult, StrResult, bail, error};
use crate::foundations::{ use crate::foundations::{
Array, Content, Func, NativeElement, NativeFunc, Packed, PlainText, Repr as _, cast, Array, Content, Func, NativeElement, NativeFunc, Packed, PlainText, Repr as _, cast,
elem, func, scope, ty, elem, func, scope, ty,
@ -52,7 +52,7 @@ pub struct Symbol(Repr);
#[derive(Clone, Eq, PartialEq, Hash)] #[derive(Clone, Eq, PartialEq, Hash)]
enum Repr { enum Repr {
/// A native symbol that has no named variant. /// A native symbol that has no named variant.
Single(char), Single(&'static str),
/// A native symbol with multiple named variants. /// A native symbol with multiple named variants.
Complex(&'static [Variant<&'static str>]), Complex(&'static [Variant<&'static str>]),
/// A symbol with multiple named variants, where some modifiers may have /// A symbol with multiple named variants, where some modifiers may have
@ -61,9 +61,9 @@ enum Repr {
Modified(Arc<(List, ModifierSet<EcoString>)>), Modified(Arc<(List, ModifierSet<EcoString>)>),
} }
/// A symbol variant, consisting of a set of modifiers, a character, and an /// A symbol variant, consisting of a set of modifiers, the variant's value, and an
/// optional deprecation message. /// optional deprecation message.
type Variant<S> = (ModifierSet<S>, char, Option<S>); type Variant<S> = (ModifierSet<S>, S, Option<S>);
/// A collection of symbols. /// A collection of symbols.
#[derive(Clone, Eq, PartialEq, Hash)] #[derive(Clone, Eq, PartialEq, Hash)]
@ -73,9 +73,9 @@ enum List {
} }
impl Symbol { impl Symbol {
/// Create a new symbol from a single character. /// Create a new symbol from a single value.
pub const fn single(c: char) -> Self { pub const fn single(value: &'static str) -> Self {
Self(Repr::Single(c)) Self(Repr::Single(value))
} }
/// Create a symbol with a static variant list. /// Create a symbol with a static variant list.
@ -85,6 +85,11 @@ impl Symbol {
Self(Repr::Complex(list)) Self(Repr::Complex(list))
} }
/// Create a symbol from a runtime char.
pub fn runtime_char(c: char) -> Self {
Self::runtime(Box::new([(ModifierSet::default(), c.into(), None)]))
}
/// Create a symbol with a runtime variant list. /// Create a symbol with a runtime variant list.
#[track_caller] #[track_caller]
pub fn runtime(list: Box<[Variant<EcoString>]>) -> Self { pub fn runtime(list: Box<[Variant<EcoString>]>) -> Self {
@ -92,15 +97,15 @@ impl Symbol {
Self(Repr::Modified(Arc::new((List::Runtime(list), ModifierSet::default())))) Self(Repr::Modified(Arc::new((List::Runtime(list), ModifierSet::default()))))
} }
/// Get the symbol's character. /// Get the symbol's value.
pub fn get(&self) -> char { pub fn get(&self) -> &str {
match &self.0 { match &self.0 {
Repr::Single(c) => *c, Repr::Single(value) => value,
Repr::Complex(_) => ModifierSet::<&'static str>::default() Repr::Complex(_) => ModifierSet::<&'static str>::default()
.best_match_in(self.variants().map(|(m, c, _)| (m, c))) .best_match_in(self.variants().map(|(m, v, _)| (m, v)))
.unwrap(), .unwrap(),
Repr::Modified(arc) => { Repr::Modified(arc) => {
arc.1.best_match_in(self.variants().map(|(m, c, _)| (m, c))).unwrap() arc.1.best_match_in(self.variants().map(|(m, v, _)| (m, v))).unwrap()
} }
} }
} }
@ -108,27 +113,27 @@ impl Symbol {
/// Try to get the function associated with the symbol, if any. /// Try to get the function associated with the symbol, if any.
pub fn func(&self) -> StrResult<Func> { pub fn func(&self) -> StrResult<Func> {
match self.get() { match self.get() {
'⌈' => Ok(crate::math::ceil::func()), "" => Ok(crate::math::ceil::func()),
'⌊' => Ok(crate::math::floor::func()), "" => Ok(crate::math::floor::func()),
'' => Ok(crate::math::accent::dash::func()), "" => Ok(crate::math::accent::dash::func()),
'⋅' | '\u{0307}' => Ok(crate::math::accent::dot::func()), "" | "\u{0307}" => Ok(crate::math::accent::dot::func()),
'¨' => Ok(crate::math::accent::dot_double::func()), "¨" => Ok(crate::math::accent::dot_double::func()),
'\u{20db}' => Ok(crate::math::accent::dot_triple::func()), "\u{20db}" => Ok(crate::math::accent::dot_triple::func()),
'\u{20dc}' => Ok(crate::math::accent::dot_quad::func()), "\u{20dc}" => Ok(crate::math::accent::dot_quad::func()),
'' => Ok(crate::math::accent::tilde::func()), "" => Ok(crate::math::accent::tilde::func()),
'´' => Ok(crate::math::accent::acute::func()), "´" => Ok(crate::math::accent::acute::func()),
'˝' => Ok(crate::math::accent::acute_double::func()), "˝" => Ok(crate::math::accent::acute_double::func()),
'˘' => Ok(crate::math::accent::breve::func()), "˘" => Ok(crate::math::accent::breve::func()),
'ˇ' => Ok(crate::math::accent::caron::func()), "ˇ" => Ok(crate::math::accent::caron::func()),
'^' => Ok(crate::math::accent::hat::func()), "^" => Ok(crate::math::accent::hat::func()),
'`' => Ok(crate::math::accent::grave::func()), "`" => Ok(crate::math::accent::grave::func()),
'¯' => Ok(crate::math::accent::macron::func()), "¯" => Ok(crate::math::accent::macron::func()),
'○' => Ok(crate::math::accent::circle::func()), "" => Ok(crate::math::accent::circle::func()),
'→' => Ok(crate::math::accent::arrow::func()), "" => Ok(crate::math::accent::arrow::func()),
'←' => Ok(crate::math::accent::arrow_l::func()), "" => Ok(crate::math::accent::arrow_l::func()),
'↔' => Ok(crate::math::accent::arrow_l_r::func()), "" => Ok(crate::math::accent::arrow_l_r::func()),
'⇀' => Ok(crate::math::accent::harpoon::func()), "" => Ok(crate::math::accent::harpoon::func()),
'↼' => Ok(crate::math::accent::harpoon_lt::func()), "" => Ok(crate::math::accent::harpoon_lt::func()),
_ => bail!("symbol {self} is not callable"), _ => bail!("symbol {self} is not callable"),
} }
} }
@ -163,7 +168,7 @@ impl Symbol {
/// The characters that are covered by this symbol. /// The characters that are covered by this symbol.
pub fn variants(&self) -> impl Iterator<Item = Variant<&str>> { pub fn variants(&self) -> impl Iterator<Item = Variant<&str>> {
match &self.0 { match &self.0 {
Repr::Single(c) => Variants::Single(Some(*c).into_iter()), Repr::Single(value) => Variants::Single(std::iter::once(*value)),
Repr::Complex(list) => Variants::Static(list.iter()), Repr::Complex(list) => Variants::Static(list.iter()),
Repr::Modified(arc) => arc.0.variants(), Repr::Modified(arc) => arc.0.variants(),
} }
@ -226,15 +231,30 @@ impl Symbol {
// A list of modifiers, cleared & reused in each iteration. // A list of modifiers, cleared & reused in each iteration.
let mut modifiers = Vec::new(); let mut modifiers = Vec::new();
let mut errors = ecow::eco_vec![];
// Validate the variants. // Validate the variants.
for (i, &Spanned { ref v, span }) in variants.iter().enumerate() { 'variants: for (i, &Spanned { ref v, span }) in variants.iter().enumerate() {
modifiers.clear(); modifiers.clear();
if v.1.is_empty() {
errors.push(if v.0.is_empty() {
error!(span, "empty default variant")
} else {
error!(span, "empty variant: {}", v.0.repr())
});
}
if !v.0.is_empty() { if !v.0.is_empty() {
// Collect all modifiers. // Collect all modifiers.
for modifier in v.0.split('.') { for modifier in v.0.split('.') {
if !is_ident(modifier) { if !is_ident(modifier) {
bail!(span, "invalid symbol modifier: {}", modifier.repr()); errors.push(error!(
span,
"invalid symbol modifier: {}",
modifier.repr()
));
continue 'variants;
} }
modifiers.push(modifier); modifiers.push(modifier);
} }
@ -245,29 +265,34 @@ impl Symbol {
// Ensure that there are no duplicate modifiers. // Ensure that there are no duplicate modifiers.
if let Some(ms) = modifiers.windows(2).find(|ms| ms[0] == ms[1]) { if let Some(ms) = modifiers.windows(2).find(|ms| ms[0] == ms[1]) {
bail!( errors.push(error!(
span, "duplicate modifier within variant: {}", ms[0].repr(); span, "duplicate modifier within variant: {}", ms[0].repr();
hint: "modifiers are not ordered, so each one may appear only once" hint: "modifiers are not ordered, so each one may appear only once"
) ));
continue 'variants;
} }
// Check whether we had this set of modifiers before. // Check whether we had this set of modifiers before.
let hash = hash128(&modifiers); let hash = hash128(&modifiers);
if let Some(&i) = seen.get(&hash) { if let Some(&i) = seen.get(&hash) {
if v.0.is_empty() { errors.push(if v.0.is_empty() {
bail!(span, "duplicate default variant"); error!(span, "duplicate default variant")
} else if v.0 == variants[i].v.0 { } else if v.0 == variants[i].v.0 {
bail!(span, "duplicate variant: {}", v.0.repr()); error!(span, "duplicate variant: {}", v.0.repr())
} else { } else {
bail!( error!(
span, "duplicate variant: {}", v.0.repr(); span, "duplicate variant: {}", v.0.repr();
hint: "variants with the same modifiers are identical, regardless of their order" hint: "variants with the same modifiers are identical, regardless of their order"
) )
} });
continue 'variants;
} }
seen.insert(hash, i); seen.insert(hash, i);
} }
if !errors.is_empty() {
return Err(errors);
}
let list = variants let list = variants
.into_iter() .into_iter()
@ -279,14 +304,14 @@ impl Symbol {
impl Display for Symbol { impl Display for Symbol {
fn fmt(&self, f: &mut Formatter) -> fmt::Result { fn fmt(&self, f: &mut Formatter) -> fmt::Result {
f.write_char(self.get()) f.write_str(self.get())
} }
} }
impl Debug for Repr { impl Debug for Repr {
fn fmt(&self, f: &mut Formatter) -> fmt::Result { fn fmt(&self, f: &mut Formatter) -> fmt::Result {
match self { match self {
Self::Single(c) => Debug::fmt(c, f), Self::Single(value) => Debug::fmt(value, f),
Self::Complex(list) => list.fmt(f), Self::Complex(list) => list.fmt(f),
Self::Modified(lists) => lists.fmt(f), Self::Modified(lists) => lists.fmt(f),
} }
@ -305,7 +330,7 @@ impl Debug for List {
impl crate::foundations::Repr for Symbol { impl crate::foundations::Repr for Symbol {
fn repr(&self) -> EcoString { fn repr(&self) -> EcoString {
match &self.0 { match &self.0 {
Repr::Single(c) => eco_format!("symbol(\"{}\")", *c), Repr::Single(value) => eco_format!("symbol({})", value.repr()),
Repr::Complex(variants) => { Repr::Complex(variants) => {
eco_format!( eco_format!(
"symbol{}", "symbol{}",
@ -341,15 +366,15 @@ fn repr_variants<'a>(
// that contain all applied modifiers. // that contain all applied modifiers.
applied_modifiers.iter().all(|am| modifiers.contains(am)) applied_modifiers.iter().all(|am| modifiers.contains(am))
}) })
.map(|(modifiers, c, _)| { .map(|(modifiers, value, _)| {
let trimmed_modifiers = let trimmed_modifiers =
modifiers.into_iter().filter(|&m| !applied_modifiers.contains(m)); modifiers.into_iter().filter(|&m| !applied_modifiers.contains(m));
if trimmed_modifiers.clone().all(|m| m.is_empty()) { if trimmed_modifiers.clone().all(|m| m.is_empty()) {
eco_format!("\"{c}\"") value.repr()
} else { } else {
let trimmed_modifiers = let trimmed_modifiers =
trimmed_modifiers.collect::<Vec<_>>().join("."); trimmed_modifiers.collect::<Vec<_>>().join(".");
eco_format!("(\"{}\", \"{}\")", trimmed_modifiers, c) eco_format!("({}, {})", trimmed_modifiers.repr(), value.repr())
} }
}) })
.collect::<Vec<_>>(), .collect::<Vec<_>>(),
@ -362,7 +387,7 @@ impl Serialize for Symbol {
where where
S: Serializer, S: Serializer,
{ {
serializer.serialize_char(self.get()) serializer.serialize_str(self.get())
} }
} }
@ -377,11 +402,11 @@ impl List {
} }
/// A value that can be cast to a symbol. /// A value that can be cast to a symbol.
pub struct SymbolVariant(EcoString, char); pub struct SymbolVariant(EcoString, EcoString);
cast! { cast! {
SymbolVariant, SymbolVariant,
c: char => Self(EcoString::new(), c), s: EcoString => Self(EcoString::new(), s),
array: Array => { array: Array => {
let mut iter = array.into_iter(); let mut iter = array.into_iter();
match (iter.next(), iter.next(), iter.next()) { match (iter.next(), iter.next(), iter.next()) {
@ -393,7 +418,7 @@ cast! {
/// Iterator over variants. /// Iterator over variants.
enum Variants<'a> { enum Variants<'a> {
Single(std::option::IntoIter<char>), Single(std::iter::Once<&'static str>),
Static(std::slice::Iter<'static, Variant<&'static str>>), Static(std::slice::Iter<'static, Variant<&'static str>>),
Runtime(std::slice::Iter<'a, Variant<EcoString>>), Runtime(std::slice::Iter<'a, Variant<EcoString>>),
} }
@ -406,7 +431,7 @@ impl<'a> Iterator for Variants<'a> {
Self::Single(iter) => Some((ModifierSet::default(), iter.next()?, None)), Self::Single(iter) => Some((ModifierSet::default(), iter.next()?, None)),
Self::Static(list) => list.next().copied(), Self::Static(list) => list.next().copied(),
Self::Runtime(list) => { Self::Runtime(list) => {
list.next().map(|(m, c, d)| (m.as_deref(), *c, d.as_deref())) list.next().map(|(m, s, d)| (m.as_deref(), s.as_str(), d.as_deref()))
} }
} }
} }
@ -415,21 +440,21 @@ impl<'a> Iterator for Variants<'a> {
/// A single character. /// A single character.
#[elem(Repr, PlainText)] #[elem(Repr, PlainText)]
pub struct SymbolElem { pub struct SymbolElem {
/// The symbol's character. /// The symbol's value.
#[required] #[required]
pub text: char, // This is called `text` for consistency with `TextElem`. pub text: EcoString, // This is called `text` for consistency with `TextElem`.
} }
impl SymbolElem { impl SymbolElem {
/// Create a new packed symbol element. /// Create a new packed symbol element.
pub fn packed(text: impl Into<char>) -> Content { pub fn packed(text: impl Into<EcoString>) -> Content {
Self::new(text.into()).pack() Self::new(text.into()).pack()
} }
} }
impl PlainText for Packed<SymbolElem> { impl PlainText for Packed<SymbolElem> {
fn plain_text(&self, text: &mut EcoString) { fn plain_text(&self, text: &mut EcoString) {
text.push(self.text); text.push_str(&self.text);
} }
} }

View File

@ -188,7 +188,7 @@ cast! {
self => self.0.into_value(), self => self.0.into_value(),
v: char => Self::new(v), v: char => Self::new(v),
v: Content => match v.to_packed::<SymbolElem>() { v: Content => match v.to_packed::<SymbolElem>() {
Some(elem) => Self::new(elem.text), Some(elem) if elem.text.chars().count() == 1 => Self::new(elem.text.chars().next().unwrap()),
None => bail!("expected a symbol"), _ => bail!("expected a single-codepoint symbol"),
}, },
} }

View File

@ -274,7 +274,7 @@ cast! {
Delimiter, Delimiter,
self => self.0.into_value(), self => self.0.into_value(),
_: NoneValue => Self::none(), _: NoneValue => Self::none(),
v: Symbol => Self::char(v.get())?, v: Symbol => Self::char(v.get().parse::<char>().map_err(|_| "expected a single-codepoint symbol")?)?,
v: char => Self::char(v)?, v: char => Self::char(v)?,
} }

View File

@ -39,7 +39,7 @@ impl From<codex::Module> for Scope {
impl From<codex::Symbol> for Symbol { impl From<codex::Symbol> for Symbol {
fn from(symbol: codex::Symbol) -> Self { fn from(symbol: codex::Symbol) -> Self {
match symbol { match symbol {
codex::Symbol::Single(c) => Symbol::single(c), codex::Symbol::Single(value) => Symbol::single(value),
codex::Symbol::Multi(list) => Symbol::list(list), codex::Symbol::Multi(list) => Symbol::list(list),
} }
} }

View File

@ -301,9 +301,7 @@ fn visit_kind_rules<'a>(
// textual elements via `TEXTUAL` grouping. However, in math, this is // textual elements via `TEXTUAL` grouping. However, in math, this is
// not desirable, so we just do it on a per-element basis. // not desirable, so we just do it on a per-element basis.
if let Some(elem) = content.to_packed::<SymbolElem>() { if let Some(elem) = content.to_packed::<SymbolElem>() {
if let Some(m) = if let Some(m) = find_regex_match_in_str(elem.text.as_str(), styles) {
find_regex_match_in_str(elem.text.encode_utf8(&mut [0; 4]), styles)
{
visit_regex_match(s, &[(content, styles)], m)?; visit_regex_match(s, &[(content, styles)], m)?;
return Ok(true); return Ok(true);
} }
@ -324,7 +322,7 @@ fn visit_kind_rules<'a>(
// Symbols in non-math content transparently convert to `TextElem` so we // Symbols in non-math content transparently convert to `TextElem` so we
// don't have to handle them in non-math layout. // don't have to handle them in non-math layout.
if let Some(elem) = content.to_packed::<SymbolElem>() { if let Some(elem) = content.to_packed::<SymbolElem>() {
let mut text = TextElem::packed(elem.text).spanned(elem.span()); let mut text = TextElem::packed(elem.text.clone()).spanned(elem.span());
if let Some(label) = elem.label() { if let Some(label) = elem.label() {
text.set_label(label); text.set_label(label);
} }
@ -1238,7 +1236,7 @@ fn visit_regex_match<'a>(
let len = if let Some(elem) = content.to_packed::<TextElem>() { let len = if let Some(elem) = content.to_packed::<TextElem>() {
elem.text.len() elem.text.len()
} else if let Some(elem) = content.to_packed::<SymbolElem>() { } else if let Some(elem) = content.to_packed::<SymbolElem>() {
elem.text.len_utf8() elem.text.len()
} else { } else {
1 // The rest are Ascii, so just one byte. 1 // The rest are Ascii, so just one byte.
}; };

View File

@ -718,9 +718,13 @@ fn symbols_model(resolver: &dyn Resolver, group: &GroupData) -> SymbolsModel {
} }
}; };
for (variant, c, deprecation) in symbol.variants() { for (variant, value, deprecation) in symbol.variants() {
let value_char = value.parse::<char>().ok();
let shorthand = |list: &[(&'static str, char)]| { let shorthand = |list: &[(&'static str, char)]| {
list.iter().copied().find(|&(_, x)| x == c).map(|(s, _)| s) value_char.and_then(|c| {
list.iter().copied().find(|&(_, x)| x == c).map(|(s, _)| s)
})
}; };
let name = complete(variant); let name = complete(variant);
@ -729,9 +733,14 @@ fn symbols_model(resolver: &dyn Resolver, group: &GroupData) -> SymbolsModel {
name, name,
markup_shorthand: shorthand(typst::syntax::ast::Shorthand::LIST), markup_shorthand: shorthand(typst::syntax::ast::Shorthand::LIST),
math_shorthand: shorthand(typst::syntax::ast::MathShorthand::LIST), math_shorthand: shorthand(typst::syntax::ast::MathShorthand::LIST),
math_class: typst_utils::default_math_class(c).map(math_class_name), // Matches `typst_layout::math::GlyphFragment::new`
codepoint: c as _, math_class: value.chars().next().and_then(|c| {
accent: typst::math::Accent::combine(c).is_some(), typst_utils::default_math_class(c).map(math_class_name)
}),
value: value.into(),
// Matches casting `Symbol` to `Accent`
accent: value_char
.is_some_and(|c| typst::math::Accent::combine(c).is_some()),
alternates: symbol alternates: symbol
.variants() .variants()
.filter(|(other, _, _)| other != &variant) .filter(|(other, _, _)| other != &variant)

View File

@ -159,7 +159,7 @@ pub struct SymbolsModel {
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct SymbolModel { pub struct SymbolModel {
pub name: EcoString, pub name: EcoString,
pub codepoint: u32, pub value: EcoString,
pub accent: bool, pub accent: bool,
pub alternates: Vec<EcoString>, pub alternates: Vec<EcoString>,
pub markup_shorthand: Option<&'static str>, pub markup_shorthand: Option<&'static str>,

Binary file not shown.

Before

Width:  |  Height:  |  Size: 511 B

After

Width:  |  Height:  |  Size: 558 B

View File

@ -21,6 +21,10 @@
("lightning", "🖄"), ("lightning", "🖄"),
("fly", "🖅"), ("fly", "🖅"),
) )
#let one = symbol(
"1",
("emoji", "1")
)
#envelope #envelope
#envelope.stamped #envelope.stamped
@ -28,6 +32,8 @@
#envelope.stamped.pen #envelope.stamped.pen
#envelope.lightning #envelope.lightning
#envelope.fly #envelope.fly
#one
#one.emoji
--- symbol-constructor-empty --- --- symbol-constructor-empty ---
// Error: 2-10 expected at least one variant // Error: 2-10 expected at least one variant
@ -82,6 +88,14 @@
("variant.duplicate", "y"), ("variant.duplicate", "y"),
) )
--- symbol-constructor-empty-variant ---
// Error: 2:3-2:5 empty default variant
// Error: 3:3-3:16 empty variant: "empty"
#symbol(
"",
("empty", "")
)
--- symbol-unknown-modifier --- --- symbol-unknown-modifier ---
// Error: 13-20 unknown symbol modifier // Error: 13-20 unknown symbol modifier
#emoji.face.garbage #emoji.face.garbage