caisin/typst
1
0
Fork 0
mirror of https://github.com/typst/typst synced 2025-05-14 04:56:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix breakable block equation overflow (#5078)

Browse Source
This commit is contained in:
Max 2024-10-01 08:01:28 +00:00 committed by GitHub
parent 4ef1096ad9
commit 8eee3ec8d1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/typst/src/math/equation.rs
View File

@ -322,10 +322,8 @@ fn layout_equation_block(
.layout_into_run(&elem.body, styles)? .layout_into_run(&elem.body, styles)?
.multiline_frame_builder(&ctx, styles); .multiline_frame_builder(&ctx, styles);
let width = full_equation_builder.size.x; let width = full_equation_builder.size.x;
let can_break =
BlockElem::breakable_in(styles) && full_equation_builder.frames.len() > 1;
let equation_builders = if can_break { let equation_builders = if BlockElem::breakable_in(styles) {
let mut rows = full_equation_builder.frames.into_iter().peekable(); let mut rows = full_equation_builder.frames.into_iter().peekable();
let mut equation_builders = vec![]; let mut equation_builders = vec![];
let mut last_first_pos = Point::zero(); let mut last_first_pos = Point::zero();

BIN
tests/ref/math-pagebreaking-single-line-numbered.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 760 B

BIN
tests/ref/math-pagebreaking-single-line.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 674 B

17
tests/suite/math/multiline.typ
View File

@ -130,6 +130,23 @@ $ a &+ b + & c \
& & c && + d \ & & c && + d \
&= 0 $ &= 0 $
--- math-pagebreaking-single-line ---
// Test breaking of single line equations.
#set page(height: 4em)
#show math.equation: set block(breakable: true)
Shouldn't overflow:
$ a + b $
--- math-pagebreaking-single-line-numbered ---
// Test breaking of single line equations with numbering.
#set page(height: 4em)
#show math.equation: set block(breakable: true)
#set math.equation(numbering: "(1)")
Shouldn't overflow:
$ a + b $
--- issue-1948-math-text-break --- --- issue-1948-math-text-break ---
// Test text with linebreaks in math. // Test text with linebreaks in math.
$ x := "a\nb\nc\nd\ne" $ $ x := "a\nb\nc\nd\ne" $