caisin/typst
1
0
Fork 0
mirror of https://github.com/typst/typst synced 2025-05-14 17:15:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix optimized linebreaks without justification (#5236)

Browse Source
This commit is contained in:
Laurenz 2024-10-18 15:10:22 +02:00 committed by GitHub
parent 6057df7c4d
commit 711a2d8807
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/typst/src/layout/inline/linebreak.rs
View File

@ -597,7 +597,7 @@ fn raw_cost(
let badness = if ratio < metrics.min_ratio(approx) { let badness = if ratio < metrics.min_ratio(approx) {
// Overfull line always has maximum cost. // Overfull line always has maximum cost.
1_000_000.0 1_000_000.0
} else if justify || ratio < 0.0 { } else if breakpoint != Breakpoint::Mandatory || justify || ratio < 0.0 {
// If the line shall be justified or needs shrinking, it has normal // If the line shall be justified or needs shrinking, it has normal
// badness with cost 100|ratio|^3. We limit the ratio to 10 as to not // badness with cost 100|ratio|^3. We limit the ratio to 10 as to not
// get to close to our maximum cost. // get to close to our maximum cost.

BIN
tests/ref/issue-5235-linebreak-optimized-without-justify.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 5.7 KiB

16
tests/suite/layout/inline/linebreak.typ
View File

@ -123,3 +123,19 @@ For info see #link("https://myhost.tld").
// - shaping that results in multiple glyphs in the same cluster // - shaping that results in multiple glyphs in the same cluster
#set text(font: "Noto Sans Thai") #set text(font: "Noto Sans Thai")
#h(85pt) งบิก #h(85pt) งบิก
--- issue-5235-linebreak-optimized-without-justify ---
#set page(width: 207pt, margin: 15pt)
#set text(11pt)
#set par(linebreaks: "simple")
Some texts feature many longer
words. Those are often exceedingly
challenging to break in a visually
pleasing way.
#set par(linebreaks: "optimized")
Some texts feature many longer
words. Those are often exceedingly
challenging to break in a visually
pleasing way.