From 622cef8e0052532e9b71f7a2484e6637095b9b79 Mon Sep 17 00:00:00 2001
From: bluebear94 <uruwi@protonmail.com>
Date: Sat, 24 Jun 2023 08:26:06 -0400
Subject: [PATCH] layout::par::collect: Treat linebreak element as whitespace
 (#1542)

Fixes #1540.
---
 library/src/layout/par.rs                 |   5 ++++-
 tests/ref/bugs/smartquotes-on-newline.png | Bin 0 -> 1625 bytes
 tests/typ/bugs/smartquotes-on-newline.typ |   7 +++++++
 3 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 tests/ref/bugs/smartquotes-on-newline.png
 create mode 100644 tests/typ/bugs/smartquotes-on-newline.typ

diff --git a/library/src/layout/par.rs b/library/src/layout/par.rs
index 6170a34d8..2d6bd96d2 100644
--- a/library/src/layout/par.rs
+++ b/library/src/layout/par.rs
@@ -609,7 +609,10 @@ fn collect<'a>(
                         elem.text().chars().next()
                     } else if child.is::<SmartQuoteElem>() {
                         Some('"')
-                    } else if child.is::<SpaceElem>() || child.is::<HElem>() {
+                    } else if child.is::<SpaceElem>()
+                        || child.is::<HElem>()
+                        || child.is::<LinebreakElem>()
+                    {
                         Some(SPACING_REPLACE)
                     } else {
                         Some(OBJ_REPLACE)
diff --git a/tests/ref/bugs/smartquotes-on-newline.png b/tests/ref/bugs/smartquotes-on-newline.png
new file mode 100644
index 0000000000000000000000000000000000000000..fdf4623ad0faee8e0b217c1a40f45378c4b598fc
GIT binary patch
literal 1625
zcma)-c{tPw7{`Azq*09=Lkz<(C~~xJO3oo+jMBPtJ#B={5LVVTW`0bK6sfji9BbBn
zpE+YRYY2m>7GuJOT?)z3x@y_&+2`4P_K$s@@AE$2f8KvS&-;Adn|Pcp`~dO*003~i
zGuGz-03x{C^I^LKu!EcF0e}$N&f3D|`q;vFu*3aGxsK%kD*Mn^`>?n4xW{S(-Tfa0
z>T8n@(3J9K_4|2QzrZC!JdCj6A+su26-n*HhnCguf{)4M#<b_H({QmSwlktLTqKJa
zy!qiBCz|^zI(y<He`UQkV2k*4A|b)?uCm=;vfvaI7#aQF`K-yj$(=6D@6NIvsbXlY
z9n_uoAMjhda*%dWHgErGF_vCWFJ?5VNnk5dC%J2zR1_{zU($B;98l(GyuJ~GpB{r9
z+^!%H;tnO(v7E)S0W73}2l2l*Hx(g0B4!K!2<iP{aa1YAnQ<80@rpGdXpoZy?BAq7
z&M9FGk7SJRB&Eu(;0tBJHsXfrJGH`^rLp5f<tu)#c}b(%1Wa|na}eYeapBO!PXMMH
zKq=*JsQ<nw3fBKP6p<V{q!-Jo!D^oDdP~PalC94Sw{uJ*bxL76t&VX{(h`c^yiRV(
zB@fd~f)VISlJI~52)RUAPO_C-Fw)Ts)|FjZSzZ-oxIm(Mvf<F?J~D?tuW`AEdzgtV
z5ASfSSc};5y)vjtbEy63_}kae%(|a9y)5YQqR3&60RYFUB?vSGyZ00VY<B(BRUH>G
zK?_kqb5Xzo5QKaw5v0&9<gDfD!xdQZCHnzTDwoi8SeZ5AybG@Ft#B*Vq?GFUQr1I@
zb`jaRDCs?F`d%kghUz8sL?7J}w5^3`(u0aECTQxSz@B!aAe=5~Ye(MQlD4<Mb^#AL
zbbX&~QiD+MPu?}D{Wf%w+w2unpWZ$V0owYk8=%Evp-QJLeU|zhx-@*+=ciGqxb)_p
z3=wLi7R3>j(V)*e+b5enG;}1?#PrtqBMAWBo{@XukOq&)ZnIj}J)g0@@L@qnI}VSd
zv(jK{V@&!o?~O<&F6vI8inO>Qj@QMd*|ao1@ihW*=FNd}z(uqD?w{kq`n;i4$_a+C
zn<gszIS`|Mv>WhJwE$aC$LCimRcwUZUE2pazcN^g#)#9kD#TQx{IiE-%WL>T1@Q4&
z%Mx@}p!EEbRexpJ#Jdv$cMP}PZgYF^SkYa+|HS(@=YJOz`o#oQeGhwp)dzxzqb;8(
zlZCTMPr<B~DsHRJmvQuqqxmi*rSEO3Vzet4knWHdQ&lFUzNi`w{KYb>{L@&^+?dvl
zIa2<s4PZo|-(hemr-Of09#u~Lr2VGI@3lFr%Is>sIKGgAsoCV-o|%!FT;2!*f@*5i
zr#jONW@hd{ka&g!SRHc8%Bt3n-*I6{q=ZuE>e?5{8$diQ$jg&4qRSIXsv4;GJu1&!
zX+-!h>Q6_~&)!i<iVpCOS7@b#j2G)EGsQw&UXY{HgMFJ`1-9+8Qo8z5JbH}7uXnYF
z-%Km$7b4LzMJpW*kxaDqWP4OfiaF${KlD>Rx>Y!}Kmn8~C@OB+UX5)bMmh1F+PlNv
zYHKD?lRTzZ&75~>4+o~KBr+?zSyJTah4G=46;g|?RCd?gH$_T&#z4bJXn+jBpkK<9
z)68<tZC57;YyQjNdy=_qmRRyVof(b!vTV&VV)KM~x;<uOM_jg<^)inTzLhmyVG`fk
zT=;Eloz&r$t;r(BM?gA0vuX6$wGfaTvZj)$VE%O7D5&U2C~>=C)A%^Pkjho;$T?~{
zYd0GMV8);i)Q@4)aiU~TgM~FeRmQ&5nBdc)Q#&`zb0}bA&~T|M(kMs70Kc`<?_%I7
zOdLo~Z-E<MOBhs@3NHWLJs7Kl@YYvmI&*D1DHLcsc+<n&#3s&U675t|zWPe&w2m@U
zF+>J9RZ^hZi@2-@q7`!MihWexr(H@(T*sjMC^ow;ux_MRH$8j&9fR&AVV~_J?Aj*o
z`=B9`9%g{wh@;92ox^;0%PH}s1T_hc6Vgf$&$_|wIkjto|8=b3=dj0riCWos)Xd{U
Ub3l~5C-cvrfyG%@So)Ix0Kc2no&W#<

literal 0
HcmV?d00001

diff --git a/tests/typ/bugs/smartquotes-on-newline.typ b/tests/typ/bugs/smartquotes-on-newline.typ
new file mode 100644
index 000000000..3180350ea
--- /dev/null
+++ b/tests/typ/bugs/smartquotes-on-newline.typ
@@ -0,0 +1,7 @@
+// Test that smart quotes are inferred correctly across newlines.
+
+---
+"test"#linebreak()"test"
+
+"test"\
+"test"