From 5e0e58d26ef656836aae8d16477bb059e97883a3 Mon Sep 17 00:00:00 2001
From: Ian Wrzesinski <133046678+wrzian@users.noreply.github.com>
Date: Wed, 11 Dec 2024 06:33:59 -0500
Subject: [PATCH] Add number-syntax edge case tests (#5560)

---
 tests/ref/double-percent.png      | Bin 0 -> 496 bytes
 tests/suite/foundations/float.typ |  20 ++++++++++++++++++++
 tests/suite/layout/length.typ     |  27 +++++++++++++++++++++++++++
 tests/suite/layout/relative.typ   |   8 ++++++++
 4 files changed, 55 insertions(+)
 create mode 100644 tests/ref/double-percent.png

diff --git a/tests/ref/double-percent.png b/tests/ref/double-percent.png
new file mode 100644
index 0000000000000000000000000000000000000000..61a0d6143cd1615b0fa0051d0442b32be6fd2491
GIT binary patch
literal 496
zcmV<M0T2F(P)<h;3K|Lk000e1NJLTq004LZ000{Z0{{R3fZDqh00036P)t-s|NsB~
z{QdLR<n-9(%ukE?>+=2f`SbJhrlzKag@yFj<nz?x{`&mXXq)S}(A908^3vhidZ+sB
z^UFzx;+eecywmN!)#94G#yES$HhSNVw3CyQ{QUgNMuo&Oc>3(}_~!2H?CkmK@#wC}
z)^MQTk+#!kn$&BZ+=Z^zaiQj?#p$ujwY9a5j*hIXtmfwC)^eiSeW~fQ&FJXp>gwu|
zk&(y8$MMbHoSdBU^75mjqwT@g;g-6}%F6cO>gu-7`||eg?(V$2yr7_<{{H@khK6)>
zbh5It#KgqGDRSzy&iUx@&|Q?$VwdpA+xFh+_xJby`~2XNx8aw%>a@-K@b&-x{>PGM
zX#fBKrb$FWRCwC$(?t%$KoCUHa+sN!nVFdxY~TMVk>bQRm`IWOt-g9ws|F#2{4<T)
z!+p|V{2p(B7K|xeUY}GJvkH@J2Eb;m)9b(-=f6v#R$*GqbBTDl5(<L3!#)6cSS;ky
zNtCL+K7Jq^m4}5<x0VvI8xPt|uyqxVkr)&Yz+`YbfMKIPn=i5Hw7}NoeBuG+6R=sW
mc0hdcSgf$!(Zdr$$lD7Fxe*U>FP1O>0000<MNUMnLSTZ(v?)OV

literal 0
HcmV?d00001

diff --git a/tests/suite/foundations/float.typ b/tests/suite/foundations/float.typ
index 716ecd6b6..a18e9f09a 100644
--- a/tests/suite/foundations/float.typ
+++ b/tests/suite/foundations/float.typ
@@ -95,3 +95,23 @@
 #float.inf \
 #(-float.inf) \
 #float.nan
+
+--- float-syntax-edge-cases ---
+// Test float syntax edge cases and which spans of text are highlighted. Valid
+// items are those not annotated with an error comment since syntax is handled
+// at parse time.
+
+#123.456e+789
+#000.000E-000
+#.9e0
+#123.E // this is a field access, so is fine syntactically
+#0.e
+#1.E+020
+// Error: 2-10 invalid number: 123.456e
+#123.456e
+// Error: 2-11 invalid number: 123.456e+
+#123.456e+
+// Error: 2-6 invalid number: .1E-
+#.1E-
+// Error: 2-4 invalid number: 0e
+#0e
diff --git a/tests/suite/layout/length.typ b/tests/suite/layout/length.typ
index 71d79da9a..3409614fd 100644
--- a/tests/suite/layout/length.typ
+++ b/tests/suite/layout/length.typ
@@ -79,3 +79,30 @@
 // Error: 2-9 invalid base-2 prefix
 // Hint: 2-9 numbers with a unit cannot have a base prefix
 #0b100pt
+
+--- number-syntax-edge-cases ---
+// Test numeric syntax edge cases with suffixes and which spans of text are
+// highlighted. Valid items are those not annotated with an error comment since
+// syntax is handled at parse time.
+
+// All fine
+#2em
+#6.3e5em
+#.5pt
+#1.2E+0%
+#1.2e-0%
+#0.0e0deg
+#5in%
+#0.%
+// Error: 2-8 invalid number suffix: hello
+#1hello
+// Error: 2-7 invalid number suffix: infr
+#1infr
+// Error: 2-5 invalid number: 2E
+#2EM
+// Error: 2-8 invalid number: .1E-
+#.1E-fr
+// Error: 2-16 invalid number: 0.1E+
+#0.1E+fr123e456
+// Error: 2-11 invalid number: .1e-
+#.1e-fr123.456
diff --git a/tests/suite/layout/relative.typ b/tests/suite/layout/relative.typ
index 958aee3d3..5a5908920 100644
--- a/tests/suite/layout/relative.typ
+++ b/tests/suite/layout/relative.typ
@@ -5,3 +5,11 @@
 #test((100% + 2pt).length, 2pt)
 #test((100% + 2pt - 2pt).length, 0pt)
 #test((56% + 2pt - 56%).ratio, 0%)
+
+--- double-percent ---
+// Test for two percent signs in a row.
+#3.1%%
+
+--- double-percent-error ---
+// Error: 7-8 the character `%` is not valid in code
+#(3.1%%)