caisin/typst
1
0
Fork 0
mirror of https://github.com/typst/typst synced 2025-08-04 02:07:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: improve error message for broken tags

Browse Source
This commit is contained in:
Tobias Schmitz 2025-07-31 00:01:05 +02:00
parent d9356abb39
commit 55bc6abb60
No known key found for this signature in database
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
crates/typst-pdf/src/tags/mod.rs
View File

@ -273,25 +273,35 @@ pub(crate) fn handle_end(
// There are overlapping tags in the tag tree. Figure whether breaking // There are overlapping tags in the tag tree. Figure whether breaking
// up the current tag stack is semantically ok. // up the current tag stack is semantically ok.
let is_pdf_ua = gc.options.standards.config.validator() == Validator::UA1; let is_pdf_ua = gc.options.standards.config.validator() == Validator::UA1;
let non_breakable = gc.tags.stack[idx + 1..] let mut is_breakable = true;
.iter() let mut non_breakable_span = Span::detached();
.find(|e| !e.kind.is_breakable(is_pdf_ua)); for e in gc.tags.stack[idx + 1..].iter() {
if let Some(entry) = non_breakable { if e.kind.is_breakable(is_pdf_ua) {
continue;
}
is_breakable = false;
if !e.span.is_detached() {
non_breakable_span = e.span;
break;
}
}
if !is_breakable {
let validator = gc.options.standards.config.validator(); let validator = gc.options.standards.config.validator();
if is_pdf_ua { if is_pdf_ua {
let ua1 = validator.as_str(); let ua1 = validator.as_str();
bail!( bail!(
entry.span, non_breakable_span,
"{ua1} error: invalid semantic structure, \ "{ua1} error: invalid semantic structure, \
this element's tag would be split up"; this element's tag would be split up";
hint: "maybe there is a `parbreak`, `colbreak`, or `pagebreak`" hint: "maybe this is caused by a `parbreak`, `colbreak`, or `pagebreak`"
); );
} else { } else {
bail!( bail!(
entry.span, non_breakable_span,
"invalid semantic structure, \ "invalid semantic structure, \
this element's tag would be split up"; this element's tag would be split up";
hint: "maybe there is a `parbreak`, `colbreak`, or `pagebreak`"; hint: "maybe this is caused by a `parbreak`, `colbreak`, or `pagebreak`";
hint: "disable tagged pdf by passing `--disable-pdf-tags`" hint: "disable tagged pdf by passing `--disable-pdf-tags`"
); );
} }