caisin/typst
1
0
Fork 0
mirror of https://github.com/typst/typst synced 2025-05-14 04:56:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Suggest accessing field if method doesn't exist (#2977)

Browse Source
This commit is contained in:
voidiz 2023-12-28 15:28:04 +01:00 committed by GitHub
parent 2dd3af937a
commit 4e5afa672f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 28 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
crates/typst/src/eval/call.rs
View File

@ -1,5 +1,5 @@
use comemo::{Prehashed, Tracked, TrackedMut};
use ecow::EcoVec;
use ecow::{eco_format, EcoVec};
use crate::diag::{bail, error, At, HintedStrResult, SourceResult, Trace, Tracepoint};
use crate::engine::Engine;
@ -99,13 +99,27 @@ impl Eval for ast::FuncCall<'_> {
field.as_str()
);
if let Value::Dict(dict) = target {
if matches!(dict.get(&field), Ok(Value::Func(_))) {
error.hint(
"to call the function stored in the dictionary, \
surround the field access with parentheses",
);
let mut field_hint = || {
if target.field(&field).is_ok() {
error.hint(eco_format!(
"did you mean to access the field `{}`?",
field.as_str()
));
}
};
match target {
Value::Dict(ref dict) => {
if matches!(dict.get(&field), Ok(Value::Func(_))) {
error.hint(
"to call the function stored in the dictionary, \
surround the field access with parentheses",
);
} else {
field_hint();
}
}
_ => field_hint(),
}
bail!(error);

1
tests/typ/compiler/dict.typ
View File

@ -119,6 +119,7 @@
)
// Error: 8-15 type dictionary has no method `nonfunc`
// Hint: 8-15 did you mean to access the field `nonfunc`?
dict.nonfunc()
}

6
tests/typ/compiler/methods.typ
View File

@ -35,6 +35,12 @@
#let numbers = ()
#numbers.fun()
---
// Error: 2:4-2:10 type content has no method `stroke`
// Hint: 2:4-2:10 did you mean to access the field `stroke`?
#let l = line(stroke: red)
#l.stroke()
---
// Error: 2:2-2:43 cannot mutate a temporary value
#let numbers = (1, 2, 3)