caisin/typst
1
0
Fork 0
mirror of https://github.com/typst/typst synced 2025-05-14 17:15:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change error when accessing non-existant label (#5571)

Browse Source
This commit is contained in:
Joshua Gawley 2024-12-18 16:52:37 +00:00 committed by GitHub
parent 257764181e
commit 21e608e6e9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crates/typst-library/src/foundations/content.rs
View File

@ -211,9 +211,10 @@ impl Content {
/// instead. /// instead.
pub fn get_by_name(&self, name: &str) -> Result<Value, FieldAccessError> { pub fn get_by_name(&self, name: &str) -> Result<Value, FieldAccessError> {
if name == "label" { if name == "label" {
if let Some(label) = self.label() { return self
return Ok(label.into_value()); .label()
} .map(|label| label.into_value())
.ok_or(FieldAccessError::Unknown);
} }
let id = self.elem().field_id(name).ok_or(FieldAccessError::Unknown)?; let id = self.elem().field_id(name).ok_or(FieldAccessError::Unknown)?;
self.get(id, None) self.get(id, None)

4
tests/suite/foundations/label.typ
View File

@ -88,3 +88,7 @@ _Visible_
#set heading(numbering: "1.") #set heading(numbering: "1.")
// Warning: 1-4 label `<a>` is not attached to anything // Warning: 1-4 label `<a>` is not attached to anything
<a> <a>
--- label-non-existent-error ---
// Error: 5-10 sequence does not have field "label"
#[].label