From 1b49034fb31e46de7a1b59de6ecf29337add41a8 Mon Sep 17 00:00:00 2001
From: Tobias Schmitz <tobiasschmitz2001@gmail.com>
Date: Tue, 5 Aug 2025 16:38:29 +0200
Subject: [PATCH] refactor: fix some warnings

---
 crates/typst-pdf/src/tags/context.rs |  6 +-----
 crates/typst-pdf/src/tags/util.rs    | 16 ----------------
 tests/src/run.rs                     |  6 ++++--
 3 files changed, 5 insertions(+), 23 deletions(-)

diff --git a/crates/typst-pdf/src/tags/context.rs b/crates/typst-pdf/src/tags/context.rs
index 9680298f3..a5d962267 100644
--- a/crates/typst-pdf/src/tags/context.rs
+++ b/crates/typst-pdf/src/tags/context.rs
@@ -148,7 +148,7 @@ impl Tags {
             }
             TagNode::Text(attrs, ids) => {
                 let tag = attrs.to_tag();
-                let children = ids.into_iter().map(|id| Node::Leaf(id)).collect();
+                let children = ids.into_iter().map(Node::Leaf).collect();
                 let group = krilla::tagging::TagGroup::with_children(tag, children);
                 Node::Group(group)
             }
@@ -210,10 +210,6 @@ impl TagStack {
         self.items.len()
     }
 
-    pub fn last(&self) -> Option<&StackEntry> {
-        self.items.last()
-    }
-
     pub fn last_mut(&mut self) -> Option<&mut StackEntry> {
         self.items.last_mut()
     }
diff --git a/crates/typst-pdf/src/tags/util.rs b/crates/typst-pdf/src/tags/util.rs
index 16489939b..26cffacbb 100644
--- a/crates/typst-pdf/src/tags/util.rs
+++ b/crates/typst-pdf/src/tags/util.rs
@@ -38,22 +38,6 @@ where
     }
 }
 
-pub trait PropertyValRef<E, T, const I: u8> {
-    /// Get a reference to the value.
-    fn val_ref(&self) -> &T;
-}
-
-impl<E, T, const I: u8> PropertyValRef<E, T, I> for Settable<E, I>
-where
-    E: NativeElement,
-    E: SettableProperty<I, Type = T>,
-    E: RefableProperty<I>,
-{
-    fn val_ref(&self) -> &T {
-        self.get_ref(StyleChain::default())
-    }
-}
-
 pub trait PropertyOptRef<E, T, const I: u8> {
     fn opt_ref(&self) -> Option<&T>;
 }
diff --git a/tests/src/run.rs b/tests/src/run.rs
index 5069dcb07..4179b25b1 100644
--- a/tests/src/run.rs
+++ b/tests/src/run.rs
@@ -535,8 +535,10 @@ impl OutputType for Pdftags {
             Ok(doc) => doc,
             Err(errors) => return Warned { output: Err(errors), warnings },
         };
-        let mut options = PdfOptions::default();
-        options.standards = PdfStandards::new(&[PdfStandard::Ua_1]).unwrap();
+        let options = PdfOptions {
+            standards: PdfStandards::new(&[PdfStandard::Ua_1]).unwrap(),
+            ..Default::default()
+        };
         let output = typst_pdf::pdf_tags(&doc, &options).map(Pdftags);
         Warned { warnings, output }
     }