caisin/typst
1
0
Fork 0
mirror of https://github.com/typst/typst synced 2025-05-14 17:15:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Appends a hint if length is expected but hint provided. (#580)

Browse Source
This commit is contained in:
astrale-sharp 2023-04-05 16:47:12 +02:00 committed by GitHub
parent 222c590788
commit 085282c138
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/eval/cast.rs
View File

@ -7,6 +7,8 @@ use ecow::EcoString;
use super::{Array, Str, Value}; use super::{Array, Str, Value};
use crate::diag::StrResult; use crate::diag::StrResult;
use crate::eval::Type;
use crate::geom::Length;
use crate::syntax::Spanned; use crate::syntax::Spanned;
use crate::util::separated_list; use crate::util::separated_list;
@ -291,6 +293,14 @@ impl CastInfo {
msg.push_str(", found "); msg.push_str(", found ");
msg.push_str(found.type_name()); msg.push_str(found.type_name());
} }
if_chain::if_chain! {
if let Value::Int(i) = found;
if parts.iter().any(|p| p == Length::TYPE_NAME);
if !matching_type;
then {
msg.push_str(&format!(": a length needs a unit – did you mean {i}pt?"));
}
};
msg.into() msg.into()
} }

6
tests/typ/compiler/hint.typ Normal file
View File

@ -0,0 +1,6 @@
// Test diagnostics.
// Ref: false
---
// Error: 1:17-1:19 expected length, found integer: a length needs a unit – did you mean 12pt?
#set text(size: 12)