From da545c266c6f1cacae2d3f4dcc1a18ae06ffadac Mon Sep 17 00:00:00 2001 From: Chris Tsang Date: Sat, 12 Jun 2021 19:48:43 +0800 Subject: [PATCH] Comments --- src/entity/column.rs | 5 +++++ src/query/helper.rs | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/entity/column.rs b/src/entity/column.rs index 3ef4c87b..52da7a2d 100644 --- a/src/entity/column.rs +++ b/src/entity/column.rs @@ -34,11 +34,16 @@ macro_rules! bind_vec_func { }; } +// LINT: when the operand value does not match column type pub trait ColumnTrait: IdenStatic + Iterable { type EntityName: EntityName; fn def(&self) -> ColumnType; + // we may add more: + // fn indexed(&self) -> bool; + // fn unique(&self) -> bool; + fn entity_name(&self) -> DynIden { SeaRc::new(Self::EntityName::default()) as DynIden } diff --git a/src/query/helper.rs b/src/query/helper.rs index af2d3fca..da01fab4 100644 --- a/src/query/helper.rs +++ b/src/query/helper.rs @@ -214,7 +214,6 @@ pub trait QueryOrder: Sized { } // LINT: when the column does not appear in tables selected from -// LINT: when the operand value does not match column type pub trait QueryFilter: Sized { type QueryStatement: ConditionalStatement;