diff --git a/Cargo.toml b/Cargo.toml index 7dfb7cb8..71690374 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -37,6 +37,7 @@ serde_json = { version = "^1", optional = true } sqlx = { version = "^0.5", optional = true } uuid = { version = "0.8", features = ["serde", "v4"], optional = true } ouroboros = "0.11" +url = "^2.2" [dev-dependencies] smol = { version = "^1.2" } diff --git a/sea-orm-cli/Cargo.toml b/sea-orm-cli/Cargo.toml index 02fddcb1..320b35cf 100644 --- a/sea-orm-cli/Cargo.toml +++ b/sea-orm-cli/Cargo.toml @@ -32,6 +32,7 @@ sea-schema = { version = "^0.2.9", default-features = false, features = [ sqlx = { version = "^0.5", default-features = false, features = [ "mysql", "postgres" ] } env_logger = { version = "^0.9" } log = { version = "^0.4" } +url = "^2.2" [features] default = [ "runtime-async-std-native-tls" ] diff --git a/sea-orm-cli/src/main.rs b/sea-orm-cli/src/main.rs index 528ce5f5..6ce8cc31 100644 --- a/sea-orm-cli/src/main.rs +++ b/sea-orm-cli/src/main.rs @@ -3,6 +3,7 @@ use dotenv::dotenv; use log::LevelFilter; use sea_orm_codegen::{EntityTransformer, OutputFile, WithSerde}; use std::{error::Error, fmt::Display, fs, io::Write, path::Path, process::Command, str::FromStr}; +use url::Url; mod cli; @@ -23,7 +24,8 @@ async fn main() { async fn run_generate_command(matches: &ArgMatches<'_>) -> Result<(), Box> { match matches.subcommand() { ("entity", Some(args)) => { - let url = args.value_of("DATABASE_URL").unwrap(); + // The database should be a valid URL that can be parsed + let url = Url::parse(args.value_of("DATABASE_URL").unwrap())?; let output_dir = args.value_of("OUTPUT_DIR").unwrap(); let include_hidden_tables = args.is_present("INCLUDE_HIDDEN_TABLES"); let tables = args @@ -33,7 +35,7 @@ async fn run_generate_command(matches: &ArgMatches<'_>) -> Result<(), Box bool { - if tables.len() > 0 { + if !tables.is_empty() { return tables.contains(&table); } @@ -43,7 +45,7 @@ async fn run_generate_command(matches: &ArgMatches<'_>) -> Result<(), Box) -> Result<(), Box { + use sea_schema::mysql::discovery::SchemaDiscovery; + use sqlx::MySqlPool; - let url_parts: Vec<&str> = url.split("/").collect(); - let schema = url_parts.last().unwrap(); - let connection = MySqlPool::connect(url).await?; - let schema_discovery = SchemaDiscovery::new(connection, schema); - let schema = schema_discovery.discover().await; - schema - .tables - .into_iter() - .filter(|schema| filter_tables(&schema.info.name)) - .filter(|schema| filter_hidden_tables(&schema.info.name)) - .map(|schema| schema.write()) - .collect() - } else if url.starts_with("postgres://") || url.starts_with("postgresql://") { - use sea_schema::postgres::discovery::SchemaDiscovery; - use sqlx::PgPool; + // TODO: as far as I can tell, this used to be the last + // value of the url, which should have been the database + // name? + let schema = url.path_segments().unwrap().last().unwrap(); + let connection = MySqlPool::connect(url.as_str()).await?; + let schema_discovery = SchemaDiscovery::new(connection, schema); + let schema = schema_discovery.discover().await; + schema + .tables + .into_iter() + .filter(|schema| filter_tables(&schema.info.name)) + .filter(|schema| filter_hidden_tables(&schema.info.name)) + .map(|schema| schema.write()) + .collect() + } + "postgres" | "postgresql" => { + use sea_schema::postgres::discovery::SchemaDiscovery; + use sqlx::PgPool; - let schema = args.value_of("DATABASE_SCHEMA").unwrap_or("public"); - let connection = PgPool::connect(url).await?; - let schema_discovery = SchemaDiscovery::new(connection, schema); - let schema = schema_discovery.discover().await; - schema - .tables - .into_iter() - .filter(|schema| filter_tables(&schema.info.name)) - .filter(|schema| filter_hidden_tables(&schema.info.name)) - .map(|schema| schema.write()) - .collect() - } else { - panic!("This database is not supported ({})", url) + let schema = args.value_of("DATABASE_SCHEMA").unwrap_or("public"); + let connection = PgPool::connect(url.as_str()).await?; + let schema_discovery = SchemaDiscovery::new(connection, schema); + let schema = schema_discovery.discover().await; + schema + .tables + .into_iter() + .filter(|schema| filter_tables(&schema.info.name)) + .filter(|schema| filter_hidden_tables(&schema.info.name)) + .map(|schema| schema.write()) + .collect() + } + _ => unimplemented!("{} is not supported", url.scheme()), }; let output = EntityTransformer::transform(table_stmts)? @@ -99,6 +105,8 @@ async fn run_generate_command(matches: &ArgMatches<'_>) -> Result<(), Box bool { + let base_url_parsed = Url::parse(base_url).unwrap(); match self { Self::Postgres => { - base_url.starts_with("postgres://") || base_url.starts_with("postgresql://") + base_url_parsed.scheme() == "postgres" || base_url_parsed.scheme() == "postgresql" } - Self::MySql => base_url.starts_with("mysql://"), - Self::Sqlite => base_url.starts_with("sqlite:"), + Self::MySql => base_url_parsed.scheme() == "mysql", + Self::Sqlite => base_url_parsed.scheme() == "sqlite", } }