From 9beca866172612a207ebb88463df7fbe1bca2465 Mon Sep 17 00:00:00 2001
From: Chris Tsang <tyt2y7@gmail.com>
Date: Thu, 10 Jun 2021 12:12:51 +0800
Subject: [PATCH] Lint ideas

---
 src/query/helper.rs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/query/helper.rs b/src/query/helper.rs
index 19ff9de4..af2d3fca 100644
--- a/src/query/helper.rs
+++ b/src/query/helper.rs
@@ -7,6 +7,9 @@ pub use sea_query::{
     Condition, ConditionalStatement, DynIden, JoinType, Order, OrderedStatement, SeaRc,
 };
 
+// LINT: when the column does not appear in tables selected from
+// LINT: when there is a group by clause, but some columns don't have aggregate functions
+// LINT: when the join table or column does not exists
 pub trait QuerySelect: Sized {
     type QueryStatement;
 
@@ -140,6 +143,7 @@ pub trait QuerySelect: Sized {
     }
 }
 
+// LINT: when the column does not appear in tables selected from
 pub trait QueryOrder: Sized {
     type QueryStatement: OrderedStatement;
 
@@ -209,6 +213,8 @@ pub trait QueryOrder: Sized {
     }
 }
 
+// LINT: when the column does not appear in tables selected from
+// LINT: when the operand value does not match column type
 pub trait QueryFilter: Sized {
     type QueryStatement: ConditionalStatement;