From 26cd0846d228886aa9457d12d90e86ecd0b9d6bf Mon Sep 17 00:00:00 2001
From: Billy Chan <ccw.billy.123@gmail.com>
Date: Mon, 6 Sep 2021 18:48:00 +0800
Subject: [PATCH] Remove generics on find_by_id

---
 src/entity/base_entity.rs | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/entity/base_entity.rs b/src/entity/base_entity.rs
index 67f817a7..cf7df8b7 100644
--- a/src/entity/base_entity.rs
+++ b/src/entity/base_entity.rs
@@ -239,23 +239,15 @@ pub trait EntityTrait: EntityName {
     ///         vec![2i32.into(), 3i32.into()]
     ///     )]);
     /// ```
-    fn find_by_id<V>(values: V) -> Select<Self>
-    where
-        V: IntoValueTuple,
-    {
+    fn find_by_id(values: <Self::PrimaryKey as PrimaryKeyTrait>::ValueType) -> Select<Self> {
         let mut select = Self::find();
         let mut keys = Self::PrimaryKey::iter();
         for v in values.into_value_tuple() {
             if let Some(key) = keys.next() {
                 let col = key.into_column();
                 select = select.filter(col.eq(v));
-            } else {
-                panic!("primary key arity mismatch");
             }
         }
-        if keys.next().is_some() {
-            panic!("primary key arity mismatch");
-        }
         select
     }